comunes/tane
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

feat(i18n): full RTL/CJK support — fonts, Japanese locale, directional fixes

Browse source 
Bundle Noto Sans Arabic + Noto Sans JP (SIL OFL 1.1) as per-glyph fallbacks
for both the UI text theme and every generated PDF, so RTL (Arabic) and CJK
render on all platforms — including desktop, where the system font may lack
them — instead of tofu. A shared pdf_fonts.dart centralizes the PDF theme and
the three label/catalog/recovery services reuse it.

Add Japanese (ja) as the CJK reference locale — fittingly, the app's own name
is Japanese (種, tane, 'seed'). Core strings translated; the rest fall back to
English via slang. Wired into supportedLocales (automatic) and the settings
picker.

Fix three physical Alignment.centerLeft -> AlignmentDirectional.centerStart in
variety_detail_screen, and make month-abbreviation and avatar-initial
truncation grapheme-safe (.characters) so CJK text is never cut mid-character.

Tests: CJK/Arabic PDF glyph render, ja locale resolution + English fallback.
The chat-bubble mirroring flagged by the audit was verified correct (already
respects Directionality) and left unchanged.
This commit is contained in:
vjrj 2026-07-14 11:11:19 +02:00
parent fe4591d747
commit 7ae6becd8f
31 changed files with 686 additions and 104 deletions
Download patch file Download diff file Expand all files Collapse all files

21
apps/app_seeds/test/services/label_sheet_service_test.dart
View file

@ -76,6 +76,27 @@ void main() {
expect(String.fromCharCodes(bytes.take(5)), '%PDF-');
});
test('buildPdf embeds CJK and Arabic glyphs (no tofu)', () async {
// Japanese (CJK) and Arabic (RTL) fall outside DejaVu's coverage; the Noto
// fallbacks in the PDF theme must render them without throwing. Guards
// against a regression that drops the fallback fonts.
final service = LabelSheetService(files: _RecordingFileService());
final bytes = await service.buildPdf(
labels: const [
LabelSheetLabel(
varietyLabel: '日本の在来種のトマト',
commonName: 'トマト',
scientificName: 'Solanum lycopersicum',
qrData: 'tane://seed?v=tomato',
),
LabelSheetLabel(varietyLabel: 'طماطم بلدية', qrData: 'tane://seed?v=x'),
],
format: LabelSheetFormat.cards,
);
expect(String.fromCharCodes(bytes.take(5)), '%PDF-');
expect(bytes.length, greaterThan(1000));
});
test('saveLabels hands the PDF to the save dialog', () async {
final files = _RecordingFileService();
final service = LabelSheetService(files: files);