tcef-notifications

comunes/tcef-notifications

Fork 0

Commit graph

Author	SHA1	Message	Date
vjrj	6d1ba439a2	fix(poller): stop infinite re-enqueue of unsendable notifications In shadow/dry-run/kill-switch modes, when the target has no token/recipient/ chat, or when not in the canary cohort, the handlers returned without marking the notification, so the poller (pendingFilter on notified:{$ne:true}) re-selected the same batch every cycle forever (observed: fcm:500 every 10s). Add a service-owned per-channel marker processedBy.<channel>, set in every terminal 'won't/can't send' branch, and exclude marked docs in pendingFilter. Unlike the shared notified/emailNotified/telegramNotified flags, processedBy is invisible to the old system, so it never suppresses a real send in prod shadow. - types.ts: NotificationDoc.processedBy?: Partial<Record<Channel, Date>> - poller.ts: pendingFilter excludes processedBy.<channel> - handlers.ts: markProcessed() in no-token/no-recipient/no-chat, decideSend=false, dead-token and telegram-blocked branches - fake-repo: dotted-path support in matching and $set/$unset - tests: regression test + processedBy assertions (86 passing)	2026-07-23 23:47:13 +02:00
vjrj	a1ed206985	Fase 1b: cableado del matcher (ingesta polling, runner shadow/full, comparador) - config: bloque matcher (MATCHER_MODE off/shadow/full, IRON_PASSWORD, audiencia, poll, batch) + validacion - db: colecciones subscriptions/activefires/notifications_shadow/matcher_state + ensureMatcherIndexes (2dsphere en notifications_shadow para el dedupe 500m) - matcher/context: MatchContext sobre Mongo real (candidatas geo $near 1000km + audiencia; dedupe geo $near 500m; lang del owner) - matcher/ingest: polling de activefires por createdAt>checkpoint (Mongo 3.2 sin change streams), checkpoint persistido en matcher_state - matcher/runner: loop shadow(->notifications_shadow)/full(->notifications), idempotente por dedupe+checkpoint - matcher/compare: comparador de shadow (shadowOnly=spam, realOnly=faltantes, contentMismatches) — el gate antes del cutover - index: arranca el matcher; fake-repo ampliado (upsert, sort, $gt/$lt) - docs/env/README actualizados 73 tests en verde, typecheck y build OK.	2026-07-13 18:07:06 +02:00
vjrj	a5ba2cdcf1	Fase 1a: driver mongodb v3.7 (produccion es MongoDB 3.2) El smoke-test contra prod revelo MongoDB 3.2.11 (EOL): el driver v6 exige >=4.2 y no conecta. Cambios: - mongodb ^3.7.4 + @types/mongodb; db.ts con useUnifiedTopology, sin retryWrites - sends.ts: deteccion de duplicate-key (11000) sin depender de MongoServerError - poller.ts: FilterQuery en vez de Filter - tests de integracion migrados de mongodb-memory-server a un fake en memoria (test/fake-repo.ts) porque no hay mongod 3.x ejecutable en hosts modernos; emula operadores ($ne/$in/$gte/$exists), $set/$unset e indice unico (11000) - docs: legacy-behavior.md §0 (entorno MongoDB 3.2, sin change streams -> fase 1b usara polling; recomendacion de upgrade de Mongo como fase propia) 47 tests en verde, typecheck y build OK. Datos reales del import: 413 pendientes FCM, 0 email, 8176 users con fireBaseToken.	2026-07-13 00:58:27 +02:00

Author

SHA1

Message

Date

vjrj

6d1ba439a2

fix(poller): stop infinite re-enqueue of unsendable notifications

In shadow/dry-run/kill-switch modes, when the target has no token/recipient/
chat, or when not in the canary cohort, the handlers returned without marking
the notification, so the poller (pendingFilter on notified:{$ne:true})
re-selected the same batch every cycle forever (observed: fcm:500 every 10s).

Add a service-owned per-channel marker processedBy.<channel>, set in every
terminal 'won't/can't send' branch, and exclude marked docs in pendingFilter.
Unlike the shared notified/emailNotified/telegramNotified flags, processedBy is
invisible to the old system, so it never suppresses a real send in prod shadow.

- types.ts: NotificationDoc.processedBy?: Partial<Record<Channel, Date>>
- poller.ts: pendingFilter excludes processedBy.<channel>
- handlers.ts: markProcessed() in no-token/no-recipient/no-chat, decideSend=false,
  dead-token and telegram-blocked branches
- fake-repo: dotted-path support in matching and $set/$unset
- tests: regression test + processedBy assertions (86 passing)

2026-07-23 23:47:13 +02:00

vjrj

a1ed206985

Fase 1b: cableado del matcher (ingesta polling, runner shadow/full, comparador)

- config: bloque matcher (MATCHER_MODE off/shadow/full, IRON_PASSWORD, audiencia,
  poll, batch) + validacion
- db: colecciones subscriptions/activefires/notifications_shadow/matcher_state +
  ensureMatcherIndexes (2dsphere en notifications_shadow para el dedupe 500m)
- matcher/context: MatchContext sobre Mongo real (candidatas geo $near 1000km +
  audiencia; dedupe geo $near 500m; lang del owner)
- matcher/ingest: polling de activefires por createdAt>checkpoint (Mongo 3.2 sin
  change streams), checkpoint persistido en matcher_state
- matcher/runner: loop shadow(->notifications_shadow)/full(->notifications),
  idempotente por dedupe+checkpoint
- matcher/compare: comparador de shadow (shadowOnly=spam, realOnly=faltantes,
  contentMismatches) — el gate antes del cutover
- index: arranca el matcher; fake-repo ampliado (upsert, sort, $gt/$lt)
- docs/env/README actualizados

73 tests en verde, typecheck y build OK.

2026-07-13 18:07:06 +02:00

vjrj

a5ba2cdcf1

Fase 1a: driver mongodb v3.7 (produccion es MongoDB 3.2)

El smoke-test contra prod revelo MongoDB 3.2.11 (EOL): el driver v6 exige >=4.2
y no conecta. Cambios:

- mongodb ^3.7.4 + @types/mongodb; db.ts con useUnifiedTopology, sin retryWrites
- sends.ts: deteccion de duplicate-key (11000) sin depender de MongoServerError
- poller.ts: FilterQuery en vez de Filter
- tests de integracion migrados de mongodb-memory-server a un fake en memoria
  (test/fake-repo.ts) porque no hay mongod 3.x ejecutable en hosts modernos;
  emula operadores ($ne/$in/$gte/$exists), $set/$unset e indice unico (11000)
- docs: legacy-behavior.md §0 (entorno MongoDB 3.2, sin change streams -> fase
  1b usara polling; recomendacion de upgrade de Mongo como fase propia)

47 tests en verde, typecheck y build OK. Datos reales del import: 413 pendientes
FCM, 0 email, 8176 users con fireBaseToken.

2026-07-13 00:58:27 +02:00

3 commits